Bug 39423

Summary: Move date/time limit values to DateComponents.h from HTMLInputElement.cpp
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, hamaji, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch (rev.2)
none
Patch (rev.3)
none
Patch (rev.4) none

Kent Tamura
Reported 2010-05-20 06:36:45 PDT
Move data/time limit values to DateComponents.h from HTMLInputElement.cpp
Attachments
Patch (6.28 KB, patch)
2010-05-20 06:41 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (rev.2) (6.45 KB, patch)
2010-05-20 07:03 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (rev.3) (6.44 KB, patch)
2010-05-20 19:24 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (rev.4) (6.51 KB, patch)
2010-05-22 08:35 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-05-20 06:41:38 PDT
Created attachment 56591 [details] Patch
Early Warning System Bot
Comment 2 2010-05-20 06:47:23 PDT
Attachment 56591 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2264362
WebKit Review Bot
Comment 3 2010-05-20 06:52:59 PDT
Attachment 56591 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2286358
WebKit Review Bot
Comment 4 2010-05-20 06:53:08 PDT
Attachment 56591 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/2284398
Kent Tamura
Comment 5 2010-05-20 07:03:19 PDT
Created attachment 56593 [details] Patch (rev.2)
Kent Tamura
Comment 6 2010-05-20 19:24:47 PDT
Created attachment 56663 [details] Patch (rev.3) --- 3 files changed, 42 insertions(+), 21 deletions(-)
Kent Tamura
Comment 7 2010-05-20 19:26:13 PDT
(In reply to comment #6) > Created an attachment (id=56663) [details] > Patch (rev.3) It fixed a typo in ChangeLog.
WebKit Review Bot
Comment 8 2010-05-22 02:32:51 PDT
Attachment 56663 [details] did not build on win: Build output: http://webkit-commit-queue.appspot.com/results/2283449
Kent Tamura
Comment 9 2010-05-22 08:00:19 PDT
(In reply to comment #8) > Attachment 56663 [details] did not build on win: > Build output: http://webkit-commit-queue.appspot.com/results/2283449 The errors were: Can't initialize non-integer static const field in a class declaration. I'll change them to inline functions.
Kent Tamura
Comment 10 2010-05-22 08:35:00 PDT
Created attachment 56778 [details] Patch (rev.4)
Kent Tamura
Comment 11 2010-05-26 01:41:44 PDT
Comment on attachment 56778 [details] Patch (rev.4) Clearing flags on attachment: 56778 Committed r60222: <http://trac.webkit.org/changeset/60222>
Kent Tamura
Comment 12 2010-05-26 01:41:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.