Bug 39411

Summary: [BREWMP] Don't include POSIX headers in WebCorePrefix.h
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beergun, commit-queue, joybro201
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2010-05-20 00:59:43 PDT
When building for BREW MP, don't include POSIX headers: <fcntl.h>, <pthread.h> and <sys/types.h>.
Attachments
Patch (1.46 KB, patch)
2010-05-20 01:03 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-05-20 01:03:18 PDT
Created attachment 56571 [details] Patch
Laszlo Gombos
Comment 2 2010-05-24 16:56:22 PDT
Comment on attachment 56571 [details] Patch > +#if !defined(BUILDING_BREWMP__) > #include <pthread.h> > +#endif Can we use HAVE(PTHREAD_H) as a guard here instead ?
Kwang Yul Seo
Comment 3 2010-05-25 01:44:57 PDT
(In reply to comment #2) > Can we use HAVE(PTHREAD_H) as a guard here instead ? I will try HAVE(XXX_H) and see if other ports build OK.
Kwang Yul Seo
Comment 4 2010-05-25 01:54:45 PDT
(In reply to comment #3) > I will try HAVE(XXX_H) and see if other ports build OK. Oops. It seems we can't use HAVE(WTF_FEATURE) macro in WebCorePrefix.h.
Kent Tamura
Comment 5 2010-06-12 19:04:44 PDT
Comment on attachment 56571 [details] Patch Looks OK.
WebKit Commit Bot
Comment 6 2010-06-12 20:41:29 PDT
Comment on attachment 56571 [details] Patch Clearing flags on attachment: 56571 Committed r61074: <http://trac.webkit.org/changeset/61074>
WebKit Commit Bot
Comment 7 2010-06-12 20:41:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.