| Summary: | [BREWMP] Add EventLoop | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> | ||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, joybro201 | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Other | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 33564 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kwang Yul Seo
2010-05-19 21:13:02 PDT
Created attachment 56557 [details]
Patch
Comment on attachment 56557 [details]
Patch
You need to remove the "No new tests (OOPS!)" line and replace it with either tests or reasons for no tests. In this case it's rather obvious that no tests are needed, but that second OOPS! will prevent the bot from being able to land this.
Created attachment 56570 [details]
Revised patch
Removed "No new tests. (OOPS!)"
Comment on attachment 56557 [details] Patch Cleared Eric Seidel's review+ from obsolete attachment 56557 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 56570 [details]
Revised patch
Looks OK though I don't know why BREW MP needs no explicit event loop.
(In reply to comment #5) > (From update of attachment 56570 [details]) > Looks OK though I don't know why BREW MP needs no explicit event loop. Thanks. Brew MP does not have have any programmable event loop. Comment on attachment 56570 [details] Revised patch Clearing flags on attachment: 56570 Committed r60896: <http://trac.webkit.org/changeset/60896> All reviewed patches have been landed. Closing bug. |