Bug 39322

Summary: [GTK] DragClientGtk::startDrag leaks GdkEvents
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 30623    
Attachments:
Description Flags
Fix memory leak xan.lopez: review+

Description Martin Robinson 2010-05-18 14:38:00 PDT
SSIA
Comment 1 Martin Robinson 2010-05-18 14:40:28 PDT
Created attachment 56414 [details]
Fix memory leak
Comment 2 Xan Lopez 2010-05-18 14:46:00 PDT
Comment on attachment 56414 [details]
Fix memory leak

>+    GdkWindow* window = gtk_widget_get_window(GTK_WIDGET(m_webView));
>+    g_object_ref(window); // This will be decremented by gdk_event_free() below.
>+    event->button.window = gtk_widget_get_window(GTK_WIDGET(m_webView));

just event->button.window = window; ?

r=me
Comment 3 Martin Robinson 2010-05-18 15:15:13 PDT
Committed r59714: <http://trac.webkit.org/changeset/59714>