Bug 39303

Summary: Web Inspector: fix some localization issues
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch aroben: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2010-05-18 11:42:22 PDT
There are a handful of localization issues that need fixed.
Attachments
Proposed patch (36.10 KB, patch)
2010-05-18 12:24 PDT, Timothy Hatcher 		aroben: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2010-05-18 12:24:49 PDT
Created attachment 56400 [details] Proposed patch
Adam Roben (:aroben)
Comment 2 2010-05-18 13:14:33 PDT
Comment on attachment 56400 [details] Proposed patch WebCore/inspector/front-end/TimelinePanel.js:899 + contentHelper._appendTextRow(WebInspector.UIString("Timer Id"), this.data.timerId); I'm surprised "Id" isn't "ID". WebCore/inspector/front-end/TimelinePanel.js:921 + contentHelper._appendTextRow(WebInspector.UIString("Mime Type"), this.data.mimeType); Should "Mime" be "MIME"? Seems like the number-formatting functions should move off of the Number object and just always use WebInspector.UIString. r=me
Timothy Hatcher
Comment 3 2010-05-18 13:23:52 PDT
Landed in r59688.
Note You need to log in before you can comment on or make changes to this bug.