Bug 39301

Summary: Geolocation LayoutTests should use standard template pattern
Product: WebKit Reporter: Steve Block <steveblock>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bulach, cjerdonek, dbates, eric, hamaji, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Steve Block
Reported 2010-05-18 10:35:23 PDT
This completes one of the TODOs from Bug 25880
Attachments
Patch (87.34 KB, patch)
2010-05-19 10:03 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-05-19 10:03:22 PDT
Created attachment 56496 [details] Patch
Steve Block
Comment 2 2010-05-19 10:13:11 PDT
The try-bot seems to be confused by the patch because it involves renaming a directory then changing some of the files in it, but the patch looks OK to me.
Eric Seidel (no email)
Comment 3 2010-05-19 10:56:23 PDT
I suspect svn-apply is missing some feature(s).
Jeremy Orlow
Comment 4 2010-05-21 02:19:47 PDT
Comment on attachment 56496 [details] Patch Looks much better! r=me LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js:117 + window.jsTestIsAsync = false; Is this necessary? LayoutTests/fast/dom/Geolocation/script-tests/enabled.js:17 + window.jsTestIsAsync = false; ditto
Steve Block
Comment 5 2010-05-21 05:01:05 PDT
Comment on attachment 56496 [details] Patch Landed manually as http://trac.webkit.org/changeset/59926 to include changes to new test added in http://trac.webkit.org/changeset/59859
Steve Block
Comment 6 2010-05-21 05:01:44 PDT
Closing bug as resolved fixed.
Note You need to log in before you can comment on or make changes to this bug.