Bug 39301 - Geolocation LayoutTests should use standard template pattern
Summary: Geolocation LayoutTests should use standard template pattern
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 10:35 PDT by Steve Block
Modified: 2010-05-21 05:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (87.34 KB, patch)
2010-05-19 10:03 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-05-18 10:35:23 PDT 
This completes one of the TODOs from Bug 25880
Comment 1 Steve Block 2010-05-19 10:03:22 PDT 
Created attachment 56496 [details]
Patch
Comment 2 Steve Block 2010-05-19 10:13:11 PDT 
The try-bot seems to be confused by the patch because it involves renaming a directory then changing some of the files in it, but the patch looks OK to me.
Comment 3 Eric Seidel (no email) 2010-05-19 10:56:23 PDT 
I suspect svn-apply is missing some feature(s).
Comment 4 Jeremy Orlow 2010-05-21 02:19:47 PDT 
Comment on attachment 56496 [details]
Patch

Looks much better!  r=me


LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js:117
 +  window.jsTestIsAsync = false;
Is this necessary?

LayoutTests/fast/dom/Geolocation/script-tests/enabled.js:17
 +  window.jsTestIsAsync = false;
ditto
Comment 5 Steve Block 2010-05-21 05:01:05 PDT 
Comment on attachment 56496 [details]
Patch

Landed manually as http://trac.webkit.org/changeset/59926 to include changes to new test added in http://trac.webkit.org/changeset/59859
Comment 6 Steve Block 2010-05-21 05:01:44 PDT 
Closing bug as resolved fixed.