Bug 39300

Summary: [GStreamer] PlatformMedia support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: atwilson, eric.carlson, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39202    
Attachments:
Description Flags
Basic support for PlatformMedia in the gst player
none
Basic support for PlatformMedia in the gst player eric.carlson: review+

Philippe Normand
Reported 2010-05-18 10:31:20 PDT
To support fullscreen (mostly like) the other players the gst player needs to implement the platformMedia method. It could return a new type of object capable of supporting the platform-dependant windowing system (NSView, GtkWidget,...) thanks to the gst xoverlay interface. I have 2 patches: - 1 adding a new GStreamerGWorld object, hold by the player - 1 adding support for gst xoverlay in GStreamerGWorld.
Attachments
Basic support for PlatformMedia in the gst player (9.44 KB, patch)
2010-05-18 11:23 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Basic support for PlatformMedia in the gst player (9.45 KB, patch)
2010-05-18 11:29 PDT, Philippe Normand 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-05-18 11:23:30 PDT
Created attachment 56392 [details] Basic support for PlatformMedia in the gst player
Philippe Normand
Comment 2 2010-05-18 11:25:30 PDT
(In reply to comment #1) > Created an attachment (id=56392) [details] > Basic support for PlatformMedia in the gst player I will wait for the second patch. I marked this one for review so I can get some feedback and hopefully submit a second patch adding the fullscreen logic to the player.
WebKit Review Bot
Comment 3 2010-05-18 11:25:48 PDT
Attachment 56392 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:22: You should add a blank line after implementation file's own header. [build/include_order] [4] WebCore/platform/graphics/gstreamer/GStreamerGWorld.h:27: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 4 2010-05-18 11:29:30 PDT
Created attachment 56393 [details] Basic support for PlatformMedia in the gst player
Philippe Normand
Comment 5 2010-05-20 23:12:14 PDT
Landed in http://trac.webkit.org/changeset/59915 Thanks!
Note You need to log in before you can comment on or make changes to this bug.