Bug 39300 – [GStreamer] PlatformMedia support

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Philippe Normand]

To support fullscreen (mostly like) the other players the gst player needs to implement the platformMedia method. It could return a new type of object capable of supporting the platform-dependant windowing system (NSView, GtkWidget,...) thanks to the gst xoverlay interface.

I have 2 patches:

- 1 adding a new GStreamerGWorld object, hold by the player
- 1 adding support for gst xoverlay in GStreamerGWorld.

[Philippe Normand]

Created attachment 56392 [details]
Basic support for PlatformMedia in the gst player

[Philippe Normand]

(In reply to comment #1)
> Created an attachment (id=56392) [details]
> Basic support for PlatformMedia in the gst player

I will wait for the second patch. I marked this one for review so I can get some feedback and hopefully submit a second patch adding the fullscreen logic to the player.

[WebKit Review Bot]

Attachment 56392 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:22:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
WebCore/platform/graphics/gstreamer/GStreamerGWorld.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Created attachment 56393 [details]
Basic support for PlatformMedia in the gst player

[Philippe Normand]

Landed in http://trac.webkit.org/changeset/59915
Thanks!