Bug 39290 – [GTK] build error without JIT

• Component: JavaScriptCore
• Status: RESOLVED DUPLICATE

[Ryuan Choi]

when building without JIT
I received below error

./JavaScriptCore/runtime/JSGlobalData.h:182: error: ‘NativeExecutable’ was not declared in this scope
./JavaScriptCore/runtime/JSGlobalData.h:182: error: template argument 1 is invalid
./JavaScriptCore/runtime/JSGlobalData.h:182: error: template argument 2 is invalid
./JavaScriptCore/runtime/JSGlobalData.h:182: error: template argument 5 is invalid
./JavaScriptCore/runtime/JSGlobalData.h:184: error: ‘NativeExecutable’ was not declared in this scope
./JavaScriptCore/runtime/JSGlobalData.h:184: error: template argument 1 is invalid

[Ryuan Choi]

Created attachment 56373 [details]
Patch

[Lucas De Marchi]

It seems that on r59637 somebody forgot to test with JIT disabled.

Adding the author of such revision in CC.

[Lucas De Marchi]

(In reply to comment #1)
> Created an attachment (id=56373) [details]
> Patch

+#if ENABLE(JIT)
     if (isHostFunction()) {
         callData.native.function = nativeFunction();
         return CallTypeHost;
     }
+#endif

Don't think this is the proper solution. nativeFunction was previously implemented in runtime/JSFunction.h as

NativeFunction nativeFunction()
{
    return *WTF::bitwise_cast<NativeFunction*>(m_data);
}

and the call you surrounded with #if ENABLE(JIT) was already there and being called also for !ENABLE(JIT)

[Ryuan Choi]

(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=56373) [details] [details]
> > Patch
> 
> +#if ENABLE(JIT)
>      if (isHostFunction()) {
>          callData.native.function = nativeFunction();
>          return CallTypeHost;
>      }
> +#endif
> 
> Don't think this is the proper solution. nativeFunction was previously implemented in runtime/JSFunction.h as
> 
> NativeFunction nativeFunction()
> {
>     return *WTF::bitwise_cast<NativeFunction*>(m_data);
> }
> 
> and the call you surrounded with #if ENABLE(JIT) was already there and being called also for !ENABLE(JIT)

I don't know too much about JIT. Just I need solution because It was replaced as JIT related
in my poor reading, I think that isHostFunction() return false when JIT feature was disabled.

isHostFunction looks return true only in two cases.
one is NativeExecutable which is JIT related class, other is VPtrHackExecutable
but VPtrHackExecutable was simply used.

does we check CallTypeHost when JIT feature was disabled?

[Ryuan Choi]

Created attachment 56380 [details]
Patch

[Ryuan Choi]

(In reply to comment #5)
> Created an attachment (id=56380) [details]
> Patch

anyway I add one missed
I removed this nativeFunction
because nativeFunction changed as JIT related and I think that it's not necessary.

please let me know if we need this function yet when JIT feature was disabled

[Gavin Barraclough]

https://bugs.webkit.org/show_bug.cgi?id=39287 got here first!

*** This bug has been marked as a duplicate of bug 29287 ***

[Eric Seidel (no email)]

Comment on attachment 56380 [details]
Patch

Clearing review flags since this bug was closed.