Bug 39247

Summary: Move rarely used data members to the rare structures, thus saving memory.
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ossy, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-05-17 15:47:03 PDT
Move rarely used data members to the rare structures, thus saving memory.
Attachments
Patch (21.73 KB, patch)
2010-05-17 15:59 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-05-17 15:59:22 PDT
Created attachment 56282 [details] Patch
Anders Carlsson
Comment 2 2010-05-17 15:59:46 PDT
<rdar://problem/7994707>
WebKit Review Bot
Comment 3 2010-05-17 16:00:24 PDT
Attachment 56282 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/style/RenderStyle.cpp:382: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/rendering/style/RenderStyle.cpp:383: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/rendering/style/RenderStyle.cpp:399: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/rendering/style/RenderStyle.cpp:465: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2010-05-17 16:04:31 PDT
Committed r59629: <http://trac.webkit.org/changeset/59629>
Eric Seidel (no email)
Comment 5 2010-05-17 16:27:30 PDT
A Qt test crashed after this commit: http://build.webkit.org/results/Qt%20Linux%20Release/r59629%20(11910)/http/tests/misc/font-face-in-multiple-segmented-faces-stderr.txt It might just be a flaky test though. Waiting for another roll.
Eric Seidel (no email)
Comment 6 2010-05-17 16:35:38 PDT
Rolled green.
Note You need to log in before you can comment on or make changes to this bug.