Bug 39242

Summary:

WinEWS should build Debug instead of Release

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, aroben, bweinstein, cjerdonek, commit-queue, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

39197

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Eric Seidel (no email)

Reported 2010-05-17 14:58:38 PDT

WinEWS should build Debug instead of Release

Attachments
Patch (1.54 KB, patch) 2010-05-17 15:00 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-05-17 15:00:41 PDT

Created attachment 56274 [details] Patch

Eric Seidel (no email)

Comment 2 2010-05-17 15:01:59 PDT

Comment on attachment 56274 [details] Patch The WinEWS automatically restarts itself (and does a clean build) every 50 builds, so it will pick this up automatically once it lands.

Eric Seidel (no email)

Comment 3 2010-05-17 15:02:31 PDT

I wonder if I need to make the same change to the cr-win-ews.

Eric Seidel (no email)

Comment 4 2010-05-17 15:02:52 PDT

We also could just move the WinEWS to a EC2 machine with 64-bit windows.

Mark Rowe (bdash)

Comment 5 2010-05-17 15:13:26 PDT

Release builds on Windows tend to be substantially slower to link than Debug builds due to link-time code generation, so this is probably a good change even if the builder was running 64-bit Windows.

Brian Weinstein

Comment 6 2010-05-17 15:51:22 PDT

(In reply to comment #5) > Release builds on Windows tend to be substantially slower to link than Debug builds due to link-time code generation, so this is probably a good change even if the builder was running 64-bit Windows. I agree with this - look at: http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/14330 and compare to http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/15539 They are both builds from the same change, and the release build took 17 minutes (almost all linking), while the debug build took 1.5 minutes. We should definitely be using debug for now.

Adam Roben (:aroben)

Comment 7 2010-05-18 06:53:08 PDT

Why does this bug depend on bug 39197?

Adam Roben (:aroben)

Comment 8 2010-05-18 06:53:37 PDT

Comment on attachment 56274 [details] Patch r=me

Eric Seidel (no email)

Comment 9 2010-05-18 11:18:39 PDT

(In reply to comment #7) > Why does this bug depend on bug 39197? I was just trying to relate the two. I often want a "related bugs" field in bugzilla which doesn't imply dependency.

WebKit Commit Bot

Comment 10 2010-05-19 22:38:23 PDT

Comment on attachment 56274 [details] Patch Clearing flags on attachment: 56274 Committed r59821: <http://trac.webkit.org/changeset/59821>

WebKit Commit Bot

Comment 11 2010-05-19 22:38:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.