Bug 39205

Summary: [GStreamer] enable gst support if USE_GSTREAMER macro is defined
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, eric, levin, scherkus
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39202    
Attachments:
Description Flags
proposed patch eric: review+

Philippe Normand
Reported 2010-05-17 01:20:22 PDT
Currently MediaPlayer.cpp includes MediaPlayerPrivateGStreamer only for the GTK port. It would be more convenient to enable the player include and creation only if USE_GSTREAMER macro is defined.
Attachments
proposed patch (2.25 KB, patch)
2010-05-17 01:31 PDT, Philippe Normand 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-05-17 01:31:09 PDT
Created attachment 56221 [details] proposed patch
Eric Seidel (no email)
Comment 2 2010-05-20 01:04:50 PDT
Comment on attachment 56221 [details] proposed patch ok. rs=me.
Eric Seidel (no email)
Comment 3 2010-05-20 01:05:27 PDT
You should CC some of the media folks on your bugs so they get to see media changes go by. (at least until they tell you not to CC them). :)
David Levin
Comment 4 2010-05-20 01:08:32 PDT
Removing atwilson and adding scherkus to get the video person :).
Eric Seidel (no email)
Comment 5 2010-05-20 01:09:35 PDT
Sorry, I'm remembering my video folks wrong. I added atwilson to a few other media bugs by mistake then too. :(
Philippe Normand
Comment 6 2010-05-20 01:45:55 PDT
Landed in http://trac.webkit.org/changeset/59825 Thanks :)
Note You need to log in before you can comment on or make changes to this bug.