Bug 39189

Summary:

Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

35784

Attachments:

Description	Flags
Proposed patch	none

Andreas Kling

Reported 2010-05-16 15:07:27 PDT

1. createImageData(ImageData imagedata) is missing - should return a new ImageData object with the same dimensions as 'imagedata' but filled with transparent black. 2. createImageData(width, height) should use the absolute values of 'width' and 'height' http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

Attachments
Proposed patch (10.14 KB, patch) 2010-05-16 15:12 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2010-05-16 15:12:19 PDT

Created attachment 56198 [details] Proposed patch

Kenneth Rohde Christiansen

Comment 2 2010-05-17 05:35:43 PDT

Comment on attachment 56198 [details] Proposed patch Looks good, r=me

WebKit Commit Bot

Comment 3 2010-05-17 10:32:57 PDT

Comment on attachment 56198 [details] Proposed patch Clearing flags on attachment: 56198 Committed r59613: <http://trac.webkit.org/changeset/59613>

WebKit Commit Bot

Comment 4 2010-05-17 10:33:01 PDT

All reviewed patches have been landed. Closing bug.

Andreas Kling

Comment 5 2010-05-31 09:17:36 PDT

Revision r59613 cherry-picked into qtwebkit-2.0 with commit bb0ec58203780dca50e158f77c8fc1196b0ddec3

Note You need to log in before you can comment on or make changes to this bug.