Bug 39189 - Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
Summary: Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35784
  Show dependency tree / graph
 
Reported: 2010-05-16 15:07 PDT by Andreas Kling
Modified: 2010-05-31 09:17 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (10.14 KB, patch)
2010-05-16 15:12 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-05-16 15:07:27 PDT 
1. createImageData(ImageData imagedata) is missing - should return a new ImageData object with the same dimensions as 'imagedata' but filled with transparent black.
2. createImageData(width, height) should use the absolute values of 'width' and 'height'

http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata
Comment 1 Andreas Kling 2010-05-16 15:12:19 PDT 
Created attachment 56198 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-05-17 05:35:43 PDT 
Comment on attachment 56198 [details]
Proposed patch

Looks good, r=me
Comment 3 WebKit Commit Bot 2010-05-17 10:32:57 PDT 
Comment on attachment 56198 [details]
Proposed patch

Clearing flags on attachment: 56198

Committed r59613: <http://trac.webkit.org/changeset/59613>
Comment 4 WebKit Commit Bot 2010-05-17 10:33:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Andreas Kling 2010-05-31 09:17:36 PDT 
Revision r59613 cherry-picked into qtwebkit-2.0 with commit bb0ec58203780dca50e158f77c8fc1196b0ddec3