Bug 39116

Summary: [Chromium] Rebaseline prototype-inheritance
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ager, dglazkov, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 39122    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Jeremy Orlow
Reported 2010-05-14 07:33:48 PDT
[Chromium] Rebaseline prototype-inheritance
Attachments
Patch (78.77 KB, patch)
2010-05-14 07:35 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-05-14 07:35:55 PDT
Created attachment 56067 [details] Patch
Jeremy Orlow
Comment 2 2010-05-14 07:41:55 PDT
Please take a look ASAP. In the mean time, this is disabled in Chromium.
Jeremy Orlow
Comment 3 2010-05-14 09:03:48 PDT
Committed r59475: <http://trac.webkit.org/changeset/59475>
Jeremy Orlow
Comment 4 2010-05-14 09:05:59 PDT
Mads, can you please verify that I've baselined the correct behavior? If not, can you educate me on what this is verifying and what I might have done wrong? Thanks! J
Dimitri Glazkov (Google)
Comment 5 2010-05-14 09:07:52 PDT
Oops -- that was bad. We should instead use the technique kbr used for WebGL and opt out of testing these objects until they are implemented on all ports. See http://trac.webkit.org/changeset/59388 for details.
Adam Barth
Comment 6 2010-05-14 23:32:43 PDT
Attachment 56067 [details] was posted by a committer and has review+, assigning to Jeremy Orlow for commit.
Adam Barth
Comment 7 2010-05-15 18:41:03 PDT
Comment on attachment 56067 [details] Patch I think this was already landed. Should we close this bug?
Jeremy Orlow
Comment 8 2010-05-17 02:10:15 PDT
Sorry
Note You need to log in before you can comment on or make changes to this bug.