Bug 39116 - [Chromium] Rebaseline prototype-inheritance
Summary: [Chromium] Rebaseline prototype-inheritance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on: 39122
Blocks:
  Show dependency tree / graph
 
Reported: 2010-05-14 07:33 PDT by Jeremy Orlow
Modified: 2010-05-17 02:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (78.77 KB, patch)
2010-05-14 07:35 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-05-14 07:33:48 PDT 
[Chromium] Rebaseline prototype-inheritance
Comment 1 Jeremy Orlow 2010-05-14 07:35:55 PDT 
Created attachment 56067 [details]
Patch
Comment 2 Jeremy Orlow 2010-05-14 07:41:55 PDT 
Please take a look ASAP.  In the mean time, this is disabled in Chromium.
Comment 3 Jeremy Orlow 2010-05-14 09:03:48 PDT 
Committed r59475: <http://trac.webkit.org/changeset/59475>
Comment 4 Jeremy Orlow 2010-05-14 09:05:59 PDT 
Mads, can you please verify that I've baselined the correct behavior?  If not, can you educate me on what this is verifying and what I might have done wrong?

Thanks!
J
Comment 5 Dimitri Glazkov (Google) 2010-05-14 09:07:52 PDT 
Oops -- that was bad. We should instead use the technique kbr used for WebGL and opt out of testing these objects until they are implemented on all ports. See http://trac.webkit.org/changeset/59388 for details.
Comment 6 Adam Barth 2010-05-14 23:32:43 PDT 
Attachment 56067 [details] was posted by a committer and has review+, assigning to Jeremy Orlow for commit.
Comment 7 Adam Barth 2010-05-15 18:41:03 PDT 
Comment on attachment 56067 [details]
Patch

I think this was already landed.  Should we close this bug?
Comment 8 Jeremy Orlow 2010-05-17 02:10:15 PDT 
Sorry