Bug 39090

Summary: Don't send mail if the only change is to the in-rietveld flag.
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ddkilzer: review+

Julie Parent
Reported 2010-05-13 15:28:42 PDT
Only used by tools, don't want to spam the world.
Attachments
Patch (1.35 KB, patch)
2010-05-13 15:34 PDT, Julie Parent 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2010-05-13 15:34:10 PDT
Created attachment 56029 [details] Patch
Adam Barth
Comment 2 2010-05-13 17:04:35 PDT
Comment on attachment 56029 [details] Patch Crazy. Looks hacky, but the whole file looks hacky... I'll give others a chance to look, but it seems reasonable to me.
Tony Chang
Comment 3 2010-05-13 17:36:09 PDT
Can we do something similar for commit-queue? Maybe just setting commit-queue? . Normally I run webkit-patch upload and manually set the commit-queue flag because I forgot to add --request-commit.
Adam Barth
Comment 4 2010-05-13 19:37:14 PDT
That's an interesting idea. I'd still like email for commit-queue+ though.
Tony Chang
Comment 5 2010-05-13 20:18:05 PDT
(In reply to comment #4) > That's an interesting idea. I'd still like email for commit-queue+ though. I agree, I still want email for commit-queue+.
Julie Parent
Comment 6 2010-05-14 13:56:44 PDT
I've separated the commit-queue request into another bug: https://bugs.webkit.org/show_bug.cgi?id=39134
David Kilzer (:ddkilzer)
Comment 7 2010-05-14 15:43:37 PDT
Comment on attachment 56029 [details] Patch r=me
Julie Parent
Comment 8 2010-05-14 15:55:34 PDT
Committed: http://trac.webkit.org/changeset/59500
Note You need to log in before you can comment on or make changes to this bug.