Bug 39084

Summary: More :visited link optimizations to reduce memory usage
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Critical CC: abarth, eric, hamaji, mitz, webkit.review.bot
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Dave Hyatt
Reported 2010-05-13 13:38:19 PDT
More :visited link optimizations to reduce memory usage
Attachments
Patch (15.20 KB, patch)
2010-05-13 13:39 PDT, Dave Hyatt 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-05-13 13:39:06 PDT
Created attachment 56015 [details] Patch
Dave Hyatt
Comment 2 2010-05-13 13:39:44 PDT
<rdar://problem/7965202>
WebKit Review Bot
Comment 3 2010-05-13 13:42:52 PDT
Attachment 56015 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/css/CSSStyleSelector.cpp:1171: One space before end of line comments [whitespace/comments] [5] WebCore/css/CSSStyleSelector.cpp:1470: One space before end of line comments [whitespace/comments] [5] WebCore/css/CSSStyleSelector.cpp:2935: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/css/CSSStyleSelector.cpp:2934: Missing space before ( in switch( [whitespace/parens] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2010-05-13 14:47:30 PDT
Comment on attachment 56015 [details] Patch Looks good, r=me!
Dave Hyatt
Comment 5 2010-05-13 14:51:51 PDT
Fixed in r59386.
WebKit Review Bot
Comment 6 2010-05-13 15:55:49 PDT
http://trac.webkit.org/changeset/59387 might have broken Qt Windows 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/59387 http://trac.webkit.org/changeset/59388 http://trac.webkit.org/changeset/59389
Shinichiro Hamaji
Comment 7 2010-05-14 09:56:02 PDT
Committed r59477: <http://trac.webkit.org/changeset/59477>
Shinichiro Hamaji
Comment 8 2010-05-14 10:01:45 PDT
(In reply to comment #7) > Committed r59477: <http://trac.webkit.org/changeset/59477> This is a small attempt to fix chromium's memory bot. Please check ChangeLog for detail.
Note You need to log in before you can comment on or make changes to this bug.