Bug 39049

Summary: [chromium] disable DRT in chromium again
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tkent: review+

Tony Chang
Reported 2010-05-12 23:08:29 PDT
[chromium] disable DRT in chromium again
Attachments
Patch (9.96 KB, patch)
2010-05-12 23:08 PDT, Tony Chang 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-05-12 23:08:53 PDT
Created attachment 55948 [details] Patch
Tony Chang
Comment 2 2010-05-12 23:10:59 PDT
Darin pointed out to me that we don't need to include features.gypi in webkit_support.gyp anymore. So we don't need to have both webkit_support.gyp and webkit_support_in_chromium.gyp. Here's the 3 sided path to having only webkit_support.gyp: 1) This patch to disable DRT building in chromium. 2) Roll DEPS into chromium. 3) Fix up chromium gyp files to use webkit_support.gyp and delete webkit_support_in_chromium.gyp 4) Re-enable DRT building in chromium.
Kent Tamura
Comment 3 2010-05-12 23:15:39 PDT
Comment on attachment 55948 [details] Patch OK
Tony Chang
Comment 4 2010-05-12 23:20:23 PDT
Committed r59346: <http://trac.webkit.org/changeset/59346>
Note You need to log in before you can comment on or make changes to this bug.