Bug 39036

Summary: Alias WebGLArray type names to TypedArray type names
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, dglazkov, eric, oliver, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 39080    
Bug Blocks: 39091    
Attachments:
Description Flags
Patch
dglazkov: review+, kbr: commit-queue-
Revised patch dglazkov: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-05-12 17:59:07 PDT
The WebGL specification is changing from the WebGL<T>Array type names to using the names in the separate TypedArray spec. Because this is a reasonably large change for developers (including ourselves) to adapt to, we want to give them a grace period during which both type names work. The current nightly builds of Firefox, for example, support both naming conventions. To address this we aim to provide new attributes on the DOMWindow object which follow the TypedArray spec's naming convention. Under the hood they will actually instantiate WebGL<T>Array C++ objects. A subsequent patch will rename the implementing classes to use the TypedArray naming convention. In the near future the aliases to the old WebGL<T>Array constructor functions will be deleted.
Attachments
Patch (35.99 KB, patch)
2010-05-12 18:09 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
Revised patch (39.50 KB, patch)
2010-05-13 13:43 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-05-12 18:09:53 PDT
Created attachment 55920 [details] Patch From the ChangeLog: Exposed the existing WebGL<T>Array constructor functions on the DOMWindow under the naming convention in the TypedArray spec. The implementations will be renamed in a subsequent bug, and the aliases to the WebGL<T>Array type names eventually removed. Ran all WebGL layout tests in Safari and Chromium.
Dimitri Glazkov (Google)
Comment 2 2010-05-13 08:55:26 PDT
Comment on attachment 55920 [details] Patch I wanted to make you change code generator to auto-generate these, but since they're temporary, ok :)
Kenneth Russell
Comment 3 2010-05-13 11:52:18 PDT
Committed r59376: <http://trac.webkit.org/changeset/59376>
WebKit Review Bot
Comment 4 2010-05-13 12:20:17 PDT
http://trac.webkit.org/changeset/59376 might have broken SnowLeopard Intel Release (Tests)
Kenneth Russell
Comment 5 2010-05-13 13:08:22 PDT
Reopening because initial patch broke tests and was rolled out.
Kenneth Russell
Comment 6 2010-05-13 13:43:45 PDT
Created attachment 56017 [details] Revised patch Revised patch including updates to global prototype and constructor tests.
Dimitri Glazkov (Google)
Comment 7 2010-05-13 13:50:03 PDT
Comment on attachment 56017 [details] Revised patch r=me again.
Kenneth Russell
Comment 8 2010-05-13 15:07:51 PDT
Committed r59388: <http://trac.webkit.org/changeset/59388>
WebKit Review Bot
Comment 9 2010-05-13 15:55:57 PDT
http://trac.webkit.org/changeset/59388 might have broken Qt Windows 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/59387 http://trac.webkit.org/changeset/59388 http://trac.webkit.org/changeset/59389
Note You need to log in before you can comment on or make changes to this bug.