Summary: | Make InlineBox use a frameRect for dimensions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dave Hyatt
2010-05-12 14:44:20 PDT
Created attachment 55905 [details]
Patch
Attachment 55905 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/InlineTextBox.h:111: More than one command on the same line [whitespace/newline] [4]
WebCore/rendering/InlineTextBox.cpp:738: One space before end of line comments [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.cpp:911: One space before end of line comments [whitespace/comments] [5]
Total errors found: 3 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Ignore the layout test results when reviewing. They shouldn't be included. Comment on attachment 55905 [details]
Patch
r=me
Is this a measurable memory regression? |