Bug 39024

Summary:

Hide in-rietveld flag for attachments

Product:

WebKit

Reporter:

Julie Parent <jparent>

Component:

Tools / Tests

Assignee:

Julie Parent <jparent>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Hides the in-rietveld flag from the UI.	ojan: review-
Once more, with correct diff'ing (used svn cp correctly this time)	ojan: review+

Description Julie Parent 2010-05-12 13:50:47 PDT

This is used by tooling only, and shouldn't clutter the UI.

Comment 1 Julie Parent 2010-05-12 14:14:01 PDT

Created attachment 55896 [details]
Hides the in-rietveld flag from the UI.

Comment 2 Ojan Vafai 2010-05-12 14:22:43 PDT

Comment on attachment 55896 [details]
Hides the in-rietveld flag from the UI.

Julie and I discussed in person. She's uploading a new patch with the cp'ed file properly svn cp'ed.

Comment 3 Julie Parent 2010-05-12 14:23:37 PDT

Created attachment 55900 [details]
Once more, with correct diff'ing (used svn cp correctly this time)

Comment 4 Ojan Vafai 2010-05-12 14:31:17 PDT

Comment on attachment 55900 [details]
Once more, with correct diff'ing (used svn cp correctly this time)

Ugh. This can't commit-queue since I'm not in committers.py as a reviewer yet.

Comment 5 Julie Parent 2010-05-12 14:34:48 PDT

Committed as http://trac.webkit.org/changeset/59271.