Bug 39024

Summary: Hide in-rietveld flag for attachments
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Hides the in-rietveld flag from the UI.
ojan: review-
Once more, with correct diff'ing (used svn cp correctly this time) ojan: review+

Julie Parent
Reported 2010-05-12 13:50:47 PDT
This is used by tooling only, and shouldn't clutter the UI.
Attachments
Hides the in-rietveld flag from the UI. (14.54 KB, patch)
2010-05-12 14:14 PDT, Julie Parent 		ojan: review-
DetailsFormatted DiffDiff
Once more, with correct diff'ing (used svn cp correctly this time) (15.33 KB, patch)
2010-05-12 14:23 PDT, Julie Parent 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2010-05-12 14:14:01 PDT
Created attachment 55896 [details] Hides the in-rietveld flag from the UI.
Ojan Vafai
Comment 2 2010-05-12 14:22:43 PDT
Comment on attachment 55896 [details] Hides the in-rietveld flag from the UI. Julie and I discussed in person. She's uploading a new patch with the cp'ed file properly svn cp'ed.
Julie Parent
Comment 3 2010-05-12 14:23:37 PDT
Created attachment 55900 [details] Once more, with correct diff'ing (used svn cp correctly this time)
Ojan Vafai
Comment 4 2010-05-12 14:31:17 PDT
Comment on attachment 55900 [details] Once more, with correct diff'ing (used svn cp correctly this time) Ugh. This can't commit-queue since I'm not in committers.py as a reviewer yet.
Julie Parent
Comment 5 2010-05-12 14:34:48 PDT
Committed as http://trac.webkit.org/changeset/59271.
Note You need to log in before you can comment on or make changes to this bug.