Bug 39016 – [Qt] Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Antonio Gomes]

methods below miss view->scroll() and view->update() calls, respectively.

void PageClientQGraphicsWidget::scroll(int dx, int dy, const QRect& rectToScroll)
 {
 #if USE(ACCELERATED_COMPOSITING)
   updateCompositingScrollPosition();
 #endif
 }
 
void PageClientQGraphicsWidget::update(const QRect & dirtyRect)
{
  if (overlay)
    overlay->update(QRectF(dirtyRect));
#if USE(ACCELERATED_COMPOSITING)
  syncLayers();
#endif
}

kenneth has a patch...

[Antonio Gomes]

Created attachment 55892 [details]
patch v1

[Antonio Gomes]

(In reply to comment #1)
> Created an attachment (id=55892) [details]
> patch v1

just created the bug and uploaded the patch on behalf of kenneth. The fix is his.

[Jesus Sanchez-Palencia]

(In reply to comment #0)
> methods below miss view->scroll() and view->update() calls, respectively.

Hmmm... my fault. =/
I had this on a previous version of that patch but something went wrong during all rounds of rebases and adding/removing APIs. =//


Thanks for fixing this! The patch LGTM.

[Laszlo Gombos]

Comment on attachment 55892 [details]
patch v1

lgtm, r+.

[Antonio Gomes]

*** Bug 39066 has been marked as a duplicate of this bug. ***

[Antonio Gomes]

*** Bug 39069 has been marked as a duplicate of this bug. ***

[Antonio Gomes]

Committed r59377: <http://trac.webkit.org/changeset/59377>