Bug 39015

Summary: [chromium] Avoid crash when msttcorefonts aren't provided
Product: WebKit Reporter: Adam Langley <agl>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch
none
patch
none
patch levin: review+, agl: commit-queue-

Attachments
patch (1.30 KB, patch)
2010-05-12 12:48 PDT, Adam Langley 		no flags
DetailsFormatted DiffDiff
patch (1.31 KB, patch)
2010-05-12 12:53 PDT, Adam Langley 		no flags
DetailsFormatted DiffDiff
patch (2.96 KB, patch)
2010-05-19 16:07 PDT, Adam Langley 		levin: review+
agl: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2010-05-12 12:48:13 PDT
Created attachment 55888 [details] patch
WebKit Review Bot
Comment 2 2010-05-12 12:51:05 PDT
Attachment 55888 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/chromium/FontCacheLinux.cpp:133: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Langley
Comment 3 2010-05-12 12:53:02 PDT
Created attachment 55889 [details] patch
Evan Martin
Comment 4 2010-05-13 00:12:15 PDT
LGTM. Might want to note what you're actually changing in the changelog. I'm not sure why this code used to work...
David Levin
Comment 5 2010-05-19 11:53:53 PDT
Why is there no layout test?
Adam Langley
Comment 6 2010-05-19 12:03:53 PDT
(In reply to comment #5) > Why is there no layout test? Our tests run with these fonts available (and they're critical to hundreds of other tests).
David Levin
Comment 7 2010-05-19 15:16:20 PDT
One last attempt, would this trigger the code path? <html> <body> <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> </body> </html>
Adam Langley
Comment 8 2010-05-19 15:27:16 PDT
(In reply to comment #7) > One last attempt, would this trigger the code path? > <html> > <body> > <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> > </body> > </html> Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead.
Adam Langley
Comment 9 2010-05-19 16:06:48 PDT
> Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead. That was shitty of me to take WebKit frustrations out on you. Thanks for finding the test case.
Adam Langley
Comment 10 2010-05-19 16:07:11 PDT
Created attachment 56529 [details] patch
Adam Langley
Comment 11 2010-05-24 14:25:39 PDT
r59835
Note You need to log in before you can comment on or make changes to this bug.