Summary: | [chromium] Avoid crash when msttcorefonts aren't provided | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Langley <agl> | ||||||||
Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Adam Langley
2010-05-12 12:45:59 PDT
Created attachment 55888 [details]
patch
Attachment 55888 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/chromium/FontCacheLinux.cpp:133: One space before end of line comments [whitespace/comments] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 55889 [details]
patch
LGTM. Might want to note what you're actually changing in the changelog. I'm not sure why this code used to work... Why is there no layout test? (In reply to comment #5) > Why is there no layout test? Our tests run with these fonts available (and they're critical to hundreds of other tests). One last attempt, would this trigger the code path? <html> <body> <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> </body> </html> (In reply to comment #7) > One last attempt, would this trigger the code path? > <html> > <body> > <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> > </body> > </html> Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead. > Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead.
That was shitty of me to take WebKit frustrations out on you. Thanks for finding the test case.
Created attachment 56529 [details]
patch
|