Summary: | [Qt] Link error in debug mode without debug_and_release config | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann, jturcotte | ||||
Priority: | P3 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2010-05-12 11:05:42 PDT
Created attachment 55872 [details]
Patch
- CONFIG(debug, debug|release):build_pass: QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d + CONFIG(debug, debug|release):QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d The QtLauncher linking break caused in debug mode caused the line above, because if config doesn't contain debug_and_release, build_pass will always false and QTWEBKITLIBNAME won't have necessarily "d" suffix. Removing build_pass guard fix this bug and won't change anything. I know modifying mkspec isn't the good solution, but it was an experiment in first step. And I found it works. I'm going to remove debug_and_release config from the WebKit build scripts to decrease the runtime of building and avoid generating unnecessarily makefiles in an other bug. Comment on attachment 55872 [details]
Patch
cq- -ed, because I would like to land it manually.
Comment on attachment 55872 [details]
Patch
Be aware that this will conflict with Laszlo's patch on the cq.
Landed, conflict resolved manually: http://trac.webkit.org/changeset/59266 |