Bug 38991

Summary:

HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement

Product:

WebKit

Reporter:

Yael <yael>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mitz: review+

Yael

Reported 2010-05-12 07:43:28 PDT

This is from the comment https://bugs.webkit.org/show_bug.cgi?id=38688#c18. This change cannot remove type casting in the code, but it is still the right thing to do.

Attachments
Patch (1.78 KB, patch) 2010-05-12 07:48 PDT, Yael	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yael

Comment 1 2010-05-12 07:48:46 PDT

Created attachment 55844 [details] Patch

mitz

Comment 2 2010-05-12 08:02:43 PDT

Comment on attachment 55844 [details] Patch > +#include "HTMLFormControlElement.h" I think a forward declaration of the class will suffice here, instead of including the header.

Yael

Comment 3 2010-05-12 08:20:03 PDT

(In reply to comment #2) > (From update of attachment 55844 [details]) > > +#include "HTMLFormControlElement.h" > > I think a forward declaration of the class will suffice here, instead of including the header. Thanks for your review. I added the header due to problem compiling DOMHTMLLabelElement.mm. Perhaps there was a better way to fix the compile error.

Yael

Comment 4 2010-05-12 12:11:42 PDT

Committed r59248: <http://trac.webkit.org/changeset/59248>

Note You need to log in before you can comment on or make changes to this bug.