Bug 38978

Summary: [chromium] add DRT back to the chromium build
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch tkent: review+

Tony Chang
Reported 2010-05-12 00:11:13 PDT
[chromium] add DRT back to the chromium build
Attachments
Patch (9.63 KB, patch)
2010-05-12 00:12 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (9.72 KB, patch)
2010-05-12 00:25 PDT, Tony Chang 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-05-12 00:12:03 PDT
Created attachment 55812 [details] Patch
Kent Tamura
Comment 2 2010-05-12 00:20:13 PDT
Comment on attachment 55812 [details] Patch > diff --git a/WebKit/chromium/WebKit.gyp b/WebKit/chromium/WebKit.gyp > index fe2d5890f787b4db96d6b8959820b4b0ec30e2c2..be69a572129ff052158fd191304bb497b7f3715f 100644 > --- a/WebKit/chromium/WebKit.gyp > +++ b/WebKit/chromium/WebKit.gyp > @@ -535,6 +535,85 @@ > ], > }, > { > + 'target_name': 'DumpRenderTree', > + 'type': 'executable', > + 'mac_bundle': 1, > + 'dependencies': [ > + 'webkit', > + '../../JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:wtf_config', > + '<(chromium_src_dir)/third_party/icu/icu.gyp:icuuc', > + '<(webkit_support_gyp):webkit_support', > + ], > + 'include_dirs': [ > + '.', > + '../../JavaScriptCore', > + '<(DEPTH)', > + ], 'include_dirs' without this patch contains 4 lines. It seems a line was removed accidentally.
Tony Chang
Comment 3 2010-05-12 00:25:23 PDT
Created attachment 55813 [details] Patch
Tony Chang
Comment 4 2010-05-12 00:26:22 PDT
(In reply to comment #2) > 'include_dirs' without this patch contains 4 lines. It seems a line was removed accidentally. Sorry, you're right! I've added the include path in the new patch.
Tony Chang
Comment 5 2010-05-12 00:46:21 PDT
Committed r59212: <http://trac.webkit.org/changeset/59212>
Note You need to log in before you can comment on or make changes to this bug.