Bug 38964

Summary: run-webkit-tests should turn smooth scrolling off on platforms that have such a notion
Product: WebKit Reporter: James Robinson <jamesr>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 38416    
Attachments:
Description Flags
Patch none

James Robinson
Reported 2010-05-11 18:56:30 PDT
Tests like http://trac.webkit.org/browser/trunk/LayoutTests/fast/repaint/fixed-move-after-keyboard-scroll.html depend on smooth scrolling being disabled. Since the default setting for smooth scrolling on Snow Leopard is on, this test fails on the Snow Leopard bots. DumpRenderTree should be smart enough to turn this off when running tests to ensure a consistent environment
Attachments
Patch (1.65 KB, patch)
2010-05-11 19:07 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-05-11 19:07:19 PDT
Created attachment 55796 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-05-11 19:14:38 PDT
Comment on attachment 55796 [details] Patch r=me
James Robinson
Comment 3 2010-05-12 11:30:30 PDT
Comment on attachment 55796 [details] Patch Clearing flags on attachment: 55796 Committed r59246: <http://trac.webkit.org/changeset/59246>
James Robinson
Comment 4 2010-05-12 11:30:35 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-05-12 12:31:02 PDT
http://trac.webkit.org/changeset/59246 might have broken Leopard Intel Release (Tests), SnowLeopard Intel Release (Tests), and GTK Linux 64-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/59243 http://trac.webkit.org/changeset/59244 http://trac.webkit.org/changeset/59245 http://trac.webkit.org/changeset/59246
Note You need to log in before you can comment on or make changes to this bug.