Bug 38964 - run-webkit-tests should turn smooth scrolling off on platforms that have such a notion
Summary: run-webkit-tests should turn smooth scrolling off on platforms that have such...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 38416
  Show dependency treegraph
 
Reported: 2010-05-11 18:56 PDT by James Robinson
Modified: 2010-05-12 12:31 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2010-05-11 19:07 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-05-11 18:56:30 PDT
Tests like http://trac.webkit.org/browser/trunk/LayoutTests/fast/repaint/fixed-move-after-keyboard-scroll.html depend on smooth scrolling being disabled.  Since the default setting for smooth scrolling on Snow Leopard is on, this test fails on the Snow Leopard bots.  DumpRenderTree should be smart enough to turn this off when running tests to ensure a consistent environment
Comment 1 James Robinson 2010-05-11 19:07:19 PDT
Created attachment 55796 [details]
Patch
Comment 2 Simon Fraser (smfr) 2010-05-11 19:14:38 PDT
Comment on attachment 55796 [details]
Patch

r=me
Comment 3 James Robinson 2010-05-12 11:30:30 PDT
Comment on attachment 55796 [details]
Patch

Clearing flags on attachment: 55796

Committed r59246: <http://trac.webkit.org/changeset/59246>
Comment 4 James Robinson 2010-05-12 11:30:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-05-12 12:31:02 PDT
http://trac.webkit.org/changeset/59246 might have broken Leopard Intel Release (Tests), SnowLeopard Intel Release (Tests), and GTK Linux 64-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/59243
http://trac.webkit.org/changeset/59244
http://trac.webkit.org/changeset/59245
http://trac.webkit.org/changeset/59246