Summary: | 19 media tests are crashing on Windows Release | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | rniwa | ||||||
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, PlatformOnly, Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
URL: | http://build.webkit.org/builders/Windows%20Release%20%28Tests%29/builds/12469 | ||||||||
Attachments: |
|
Description
Jer Noble
2010-05-11 16:54:44 PDT
Created attachment 55780 [details]
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF.
Linking directly against WTF.lib instead of indirectly through JavaScriptCore.lib causes free and malloc to duplicated inside QTMovieWin.dll. This causes a malloc/free mismatch which shows up only in Release builds.
This originally showed up in r59001 when QTMovie, QTMovieGWorld, and QTMovieVisualContext were changed to inherit from WTF::RefCounted, so that each could be contained in a RefPtr. Testing 93 test cases. media ............................................................................................. 48.38s total testing time all 93 test cases succeeded Created attachment 55782 [details]
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF.
This time, with a ChangeLog.
Committed r59190: <http://trac.webkit.org/changeset/59190> Fixed the change log entry in http://trac.webkit.org/changeset/100243. |