Bug 38950

Summary: 19 media tests are crashing on Windows Release
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2 Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://build.webkit.org/builders/Windows%20Release%20%28Tests%29/builds/12469
Attachments:
Description Flags
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF.
none
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF. darin: review+

Jer Noble
Reported 2010-05-11 16:54:44 PDT
Since r59001, 19 media tests have been crashing on Windows Release.
Attachments
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF. (3.09 KB, patch)
2010-05-11 17:14 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF. (3.80 KB, patch)
2010-05-11 17:20 PDT, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2010-05-11 17:14:16 PDT
Created attachment 55780 [details] QTMovieWin.vcproj: link against JavaScriptCore instead of WTF. Linking directly against WTF.lib instead of indirectly through JavaScriptCore.lib causes free and malloc to duplicated inside QTMovieWin.dll. This causes a malloc/free mismatch which shows up only in Release builds.
Jer Noble
Comment 2 2010-05-11 17:15:10 PDT
This originally showed up in r59001 when QTMovie, QTMovieGWorld, and QTMovieVisualContext were changed to inherit from WTF::RefCounted, so that each could be contained in a RefPtr.
Jer Noble
Comment 3 2010-05-11 17:17:08 PDT
Testing 93 test cases. media ............................................................................................. 48.38s total testing time all 93 test cases succeeded
Jer Noble
Comment 4 2010-05-11 17:20:58 PDT
Created attachment 55782 [details] QTMovieWin.vcproj: link against JavaScriptCore instead of WTF. This time, with a ChangeLog.
Jer Noble
Comment 5 2010-05-11 17:43:04 PDT
Committed r59190: <http://trac.webkit.org/changeset/59190>
Ryosuke Niwa
Comment 6 2011-11-14 23:02:57 PST
Fixed the change log entry in http://trac.webkit.org/changeset/100243.
Note You need to log in before you can comment on or make changes to this bug.