Bug 38944

Summary:	check-webkit-style gives style error about DEFINE_GLOBAL macro
Product:	WebKit	Reporter:	Brian Weinstein <bweinstein>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	Hironori.Fujii
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	PC
OS:	OS X 10.5

Brian Weinstein

Reported 2010-05-11 15:50:27 PDT

JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] DEFINE_GLOBAL is a macro, and we have a lot of underscores in other macros, so this is a bug in check-webkit-style.

Attachments
Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2017-11-02 16:09:39 PDT

DEFINE_GLOBAL was removed in Bug 174979.

Note You need to log in before you can comment on or make changes to this bug.