Summary: | 3% PLT Regression from moving strings into WTF | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||||||||||
Component: | Page Loading | Assignee: | Brian Weinstein <bweinstein> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, barraclough, cjerdonek, eric, hamaji, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Windows 7 | ||||||||||||||
Bug Depends on: | 38933 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Brian Weinstein
2010-05-11 12:55:59 PDT
Created attachment 55743 [details]
[PATCH] Fix
Attachment 55743 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/text/StringStatics.cpp:32: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:52: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:53: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:54: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 8 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 55748 [details]
Patch
Attachment 55748 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/text/StringStatics.cpp:32: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:52: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:53: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:54: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 8 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
As I suspect you're already aware, this broke a bunch of builders. http://build.webkit.org/console I'm sorry the EWS bots aren't faster so as to help us catch these sooner. I'll work on making them poll more often. http://trac.webkit.org/changeset/59171 might have broken Qt Linux Release minimal Created attachment 55766 [details]
Patch
Attachment 55766 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/2174143 Attachment 55766 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/text/StringStatics.cpp:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
JavaScriptCore/wtf/text/StringStatics.cpp:32: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:52: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:53: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:54: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:80: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Total errors found: 88 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Looks like a bug in check-webkit-style. (In reply to comment #10) > Looks like a bug in check-webkit-style. Filed: https://bugs.webkit.org/show_bug.cgi?id=38944 Created attachment 55770 [details]
Patch
Attachment 55770 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/text/StringStatics.cpp:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
JavaScriptCore/wtf/text/StringStatics.cpp:32: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:52: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:53: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:54: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 88 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 55770 [details]
Patch
r=me
Created attachment 55793 [details]
Patch
Comment on attachment 55793 [details]
Patch
r=me
I think this broke linking on Gtk: ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::String::length() const' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::String::isEmpty() const' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::AtomicString::add(WebCore::StringImpl*)' collect2: ld returned 1 exit status But it could have been http://trac.webkit.org/changeset/59197 instead. Unsure. |