Bug 38905 – Include missing header - PageGroup.h

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Lucas De Marchi]

PageGroup.h is needed in function ewk_init and was missing in ewk_main.cpp.

[Lucas De Marchi]

Created attachment 55700 [details]
Include missing header

This patch fixes this bug.

[Jeremy Orlow]

Comment on attachment 55700 [details]
Include missing header

r=me

[Lucas De Marchi]

Comment on attachment 55700 [details]
Include missing header

patch is malformed

[Lucas De Marchi]

Created attachment 55709 [details]
Include missing header

Prior patch was malformed. This one fix the problem.

[WebKit Commit Bot]

Comment on attachment 55709 [details]
Include missing header

Rejecting patch 55709 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Last 500 characters of output:
 that name could be found
Testing 18333 test cases.
media/video-loop.html -> timed out
Sampling process 64560 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 64560 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 14929 tests run.
349.25s total testing time

14928 test cases (99%) succeeded
1 test case (<1%) timed out
11 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/2172155

[Gustavo Sverzut Barbieri]

Could someone (Eric?) check that, given the patch it is clearly not related to this patch. The patch just touches WebKit/efl/ewk/ewk_main.cpp!

[Eric Seidel (no email)]

Comment on attachment 55709 [details]
Include missing header

This was bug 38912.

[WebKit Commit Bot]

Comment on attachment 55709 [details]
Include missing header

Clearing flags on attachment: 55709

Committed r59453: <http://trac.webkit.org/changeset/59453>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.