Bug 38894

Summary: [chromium] Remove subframe scrollbar routing (r58937)
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, fishd, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Tony Chang
Reported 2010-05-11 01:50:28 PDT
[chromium] Remove subframe scrollbar routing (r58937)
Attachments
Patch (4.08 KB, patch)
2010-05-11 01:50 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-05-11 01:50:58 PDT
Created attachment 55677 [details] Patch
Tony Chang
Comment 2 2010-05-11 01:53:25 PDT
This is basically a revert of r58937, but it keeps the test. It also runs the test on windows because the test should pass there. This makes Chromium behave like Safari Win and QT in how events to subframe scrollbars are routed.
Antonio Gomes
Comment 3 2010-05-11 07:12:00 PDT
LTGM, thank you Tony. Also there is a few more open issues regarding hittesting or general event handling involving scrollbars. I raised discussion in this thread: http://permalink.gmane.org/gmane.os.opendarwin.webkit.devel/12725 ... feel free to join.
Tony Chang
Comment 4 2010-05-11 20:53:43 PDT
Comment on attachment 55677 [details] Patch Clearing flags on attachment: 55677 Committed r59203: <http://trac.webkit.org/changeset/59203>
Tony Chang
Comment 5 2010-05-11 20:53:50 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-05-11 21:30:07 PDT
http://trac.webkit.org/changeset/59203 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/59202 http://trac.webkit.org/changeset/59203
Note You need to log in before you can comment on or make changes to this bug.