Bug 38894 - [chromium] Remove subframe scrollbar routing (r58937)
Summary: [chromium] Remove subframe scrollbar routing (r58937)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 01:50 PDT by Tony Chang
Modified: 2010-05-11 21:30 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.08 KB, patch)
2010-05-11 01:50 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-05-11 01:50:28 PDT
[chromium] Remove subframe scrollbar routing (r58937)
Comment 1 Tony Chang 2010-05-11 01:50:58 PDT
Created attachment 55677 [details]
Patch
Comment 2 Tony Chang 2010-05-11 01:53:25 PDT
This is basically a revert of r58937, but it keeps the test.  It also runs the test on windows because the test should pass there.  This makes Chromium behave like Safari Win and QT in how events to subframe scrollbars are routed.
Comment 3 Antonio Gomes 2010-05-11 07:12:00 PDT
LTGM, thank you Tony.

Also there is a few more open issues regarding hittesting or general event handling involving scrollbars. I raised discussion in this thread:

http://permalink.gmane.org/gmane.os.opendarwin.webkit.devel/12725

... feel free to join.
Comment 4 Tony Chang 2010-05-11 20:53:43 PDT
Comment on attachment 55677 [details]
Patch

Clearing flags on attachment: 55677

Committed r59203: <http://trac.webkit.org/changeset/59203>
Comment 5 Tony Chang 2010-05-11 20:53:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-05-11 21:30:07 PDT
http://trac.webkit.org/changeset/59203 might have broken Qt Linux Release minimal
The following changes are on the blame list:
http://trac.webkit.org/changeset/59202
http://trac.webkit.org/changeset/59203