Bug 38884

Summary: test-webkitpy fails on windows due to lack of readline module
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue, dpranke, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-05-10 20:14:59 PDT
test-webkitpy fails on windows due to lack of readline module
Attachments
Patch (2.12 KB, patch)
2010-05-10 20:17 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-05-10 20:17:39 PDT
Created attachment 55651 [details] Patch
Eric Seidel (no email)
Comment 2 2010-05-10 20:18:54 PDT
This brings us one step closer to test-webkitpy working under Win32 python.
Adam Barth
Comment 3 2010-05-10 20:30:01 PDT
Comment on attachment 55651 [details] Patch ok
Eric Seidel (no email)
Comment 4 2010-05-10 20:34:31 PDT
We could autoinstall http://newcenturycomputers.net/projects/readline.html on win32 python if necessary.
WebKit Commit Bot
Comment 5 2010-05-12 21:12:30 PDT
Comment on attachment 55651 [details] Patch Clearing flags on attachment: 55651 Committed r59340: <http://trac.webkit.org/changeset/59340>
WebKit Commit Bot
Comment 6 2010-05-12 21:12:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.