Bug 38873

Summary: [V8] Fix V8 code generator script to generate the correct code for converting ScriptString
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch abarth: review+, jianli: commit-queue-

Jian Li
Reported 2010-05-10 15:41:34 PDT
This is caused by r58921 which I introduced the wrong V8 generator code.
Attachments
Proposed Patch (3.44 KB, patch)
2010-05-10 15:46 PDT, Jian Li 		abarth: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-05-10 15:46:47 PDT
Created attachment 55613 [details] Proposed Patch
Adam Barth
Comment 2 2010-05-10 15:51:16 PDT
Comment on attachment 55613 [details] Proposed Patch WebCore/bindings/scripts/CodeGeneratorV8.pm:  + return "v8StringOrNull(exec, $value)" if $conv; Oh, sorry. I should have caught that in review. :(
Jian Li
Comment 3 2010-05-10 16:39:06 PDT
Committed as http://trac.webkit.org/changeset/59104.
Note You need to log in before you can comment on or make changes to this bug.