Bug 38866

Summary:

webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, jparent

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Ojan Vafai

Reported 2010-05-10 14:12:50 PDT

webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID

Attachments
Patch (6.45 KB, patch) 2010-05-10 14:16 PDT, Ojan Vafai	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2010-05-10 14:16:25 PDT

Created attachment 55602 [details] Patch

Ojan Vafai

Comment 2 2010-05-10 14:20:06 PDT

Julie is changing bugzilla to have a has_rietveld flag and to use the bugzilla ID as the rietveld issue ID. Once we have that, I'll update the upload script to set that bit on the uploaded attachment as well. Then all we'll need to get this all working is a bot that polls new patches and uploads them to rietveld.

Adam Barth

Comment 3 2010-05-12 15:20:47 PDT

Comment on attachment 55602 [details] Patch LGTM. I like this design better.

Ojan Vafai

Comment 4 2010-05-12 16:55:40 PDT

Committed r59284: <http://trac.webkit.org/changeset/59284>

Note You need to log in before you can comment on or make changes to this bug.