Bug 38825

Summary: HTMLInputElement::size not available through Chromium WebInputElement interface
Product: WebKit Reporter: David Holloway <dhollowa>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, dhollowa, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Rewording in change log.
fishd: review-
Removed tabs. none

David Holloway
Reported 2010-05-09 17:12:05 PDT
The Chromium WebInputElement interface does not provide an accessor to HTMLInputElement::size(). During form AutoFill Chromium needs to access the input element's size attribute in aid of form matching and filling heuristics. Files in question: WebKit/chromium/public/WebInputElement.h WebKit/chromium/src/WebInputElement.cpp Expected: WebKit::WebInputElement::size() method should exist and provide value of HTMLInputElement::siz().
Attachments
Patch (1.97 KB, patch)
2010-05-09 17:20 PDT, David Holloway 		no flags
DetailsFormatted DiffDiff
Rewording in change log. (1.96 KB, patch)
2010-05-10 11:00 PDT, David Holloway 		fishd: review-
DetailsFormatted DiffDiff
Removed tabs. (1.97 KB, patch)
2010-05-10 12:51 PDT, David Holloway 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Holloway
Comment 1 2010-05-09 17:20:05 PDT
Created attachment 55512 [details] Patch
David Holloway
Comment 2 2010-05-10 11:00:29 PDT
Created attachment 55574 [details] Rewording in change log. Rewording in change log.
WebKit Review Bot
Comment 3 2010-05-10 11:07:27 PDT
Attachment 55574 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Fisher (:fishd, Google)
Comment 4 2010-05-10 12:19:15 PDT
Comment on attachment 55574 [details] Rewording in change log. WebKit/chromium/ChangeLog:7 + access the input element's size attribute in aid of form matching and replace tabs with spaces. otherwise LGTM
David Holloway
Comment 5 2010-05-10 12:51:17 PDT
Created attachment 55592 [details] Removed tabs. Removed tabs.
WebKit Commit Bot
Comment 6 2010-05-11 15:39:32 PDT
Comment on attachment 55592 [details] Removed tabs. Clearing flags on attachment: 55592 Committed r59176: <http://trac.webkit.org/changeset/59176>
WebKit Commit Bot
Comment 7 2010-05-11 15:39:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.