Bug 38821

Summary:

Calling Node::setDocument() to change the document has no effect

Product:

WebKit

Reporter:

Chris Jerdonek <cjerdonek>

Component:

WebCore Misc.

Assignee:

Chris Jerdonek <cjerdonek>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Chris Jerdonek

Reported 2010-05-09 15:17:19 PDT

Node::setDocument() does nothing if the caller attempts to change the document of a node using it. To avoid the mistake of trying to use setDocument() to change the document of a node (without first removing the node from its document), we may want to assert at the beginning that the caller is not attempting to do this.

Attachments
Proposed patch (1.76 KB, patch) 2010-05-09 16:54 PDT, Chris Jerdonek	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Jerdonek

Comment 1 2010-05-09 16:54:15 PDT

Created attachment 55511 [details] Proposed patch

WebKit Commit Bot

Comment 2 2010-05-10 04:41:05 PDT

Comment on attachment 55511 [details] Proposed patch Clearing flags on attachment: 55511 Committed r59072: <http://trac.webkit.org/changeset/59072>

WebKit Commit Bot

Comment 3 2010-05-10 04:41:09 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 4 2010-05-10 05:00:54 PDT

http://trac.webkit.org/changeset/59072 might have broken Qt Linux ARMv5 Release

Note You need to log in before you can comment on or make changes to this bug.