Bug 38818

Summary: [Qt] Organize the Skipped file
Product: WebKit Reporter: Robert Hogan <robert>
Component: Tools / TestsAssignee: Robert Hogan <robert>
Status: CLOSED FIXED    
Severity: Normal CC: hausmann, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
New Skipped File none

Robert Hogan
Reported 2010-05-09 11:49:53 PDT
Put some structure on the skipped file.
Attachments
Patch (168.91 KB, patch)
2010-05-09 11:52 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
New Skipped File (201.63 KB, text/plain)
2010-05-09 11:53 PDT, Robert Hogan 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2010-05-09 11:52:07 PDT
Created attachment 55504 [details] Patch This will go out of date quite quickly so a quick review appreciated!
Robert Hogan
Comment 2 2010-05-09 11:53:18 PDT
Created attachment 55505 [details] New Skipped File This is how the re-organized looks - probably better off reading this rather than the patch.
Kenneth Rohde Christiansen
Comment 3 2010-05-09 16:31:28 PDT
Comment on attachment 55504 [details] Patch Before committing this talk to Simon, because we probably need to cherrypick it into the release branch because feature patches touching the Skipped file will depend on this.
Robert Hogan
Comment 4 2010-05-10 10:52:37 PDT
(In reply to comment #3) > (From update of attachment 55504 [details]) > Before committing this talk to Simon, because we probably need to cherrypick it into the release branch because feature patches touching the Skipped file will depend on this. Good thought - Simon, give me the nod when it's OK to commit.
Simon Hausmann
Comment 5 2010-06-07 05:46:47 PDT
Sounds good. I guess we just have to resolve the conflicts manually anyway. A cleanup sounds worth it.
Robert Hogan
Comment 6 2010-06-07 08:12:02 PDT
Landed as http://trac.webkit.org/changeset/60782
Note You need to log in before you can comment on or make changes to this bug.