Bug 38818 - [Qt] Organize the Skipped file
Summary: [Qt] Organize the Skipped file
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-05-09 11:49 PDT by Robert Hogan
Modified: 2010-06-07 08:12 PDT (History)
2 users (show)

See Also:


Attachments
Patch (168.91 KB, patch)
2010-05-09 11:52 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff
New Skipped File (201.63 KB, text/plain)
2010-05-09 11:53 PDT, Robert Hogan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-05-09 11:49:53 PDT
Put some structure on the skipped file.
Comment 1 Robert Hogan 2010-05-09 11:52:07 PDT
Created attachment 55504 [details]
Patch

This will go out of date quite quickly so a quick review appreciated!
Comment 2 Robert Hogan 2010-05-09 11:53:18 PDT
Created attachment 55505 [details]
New Skipped File

This is how the re-organized looks - probably better off reading this rather than the patch.
Comment 3 Kenneth Rohde Christiansen 2010-05-09 16:31:28 PDT
Comment on attachment 55504 [details]
Patch

Before committing this talk to Simon, because we probably need to cherrypick it into the release branch because feature patches touching the Skipped file will depend on this.
Comment 4 Robert Hogan 2010-05-10 10:52:37 PDT
(In reply to comment #3)
> (From update of attachment 55504 [details])
> Before committing this talk to Simon, because we probably need to cherrypick it into the release branch because feature patches touching the Skipped file will depend on this.

Good thought - Simon, give me the nod when it's OK to commit.
Comment 5 Simon Hausmann 2010-06-07 05:46:47 PDT
Sounds good. I guess we just have to resolve the conflicts manually anyway. A cleanup sounds worth it.
Comment 6 Robert Hogan 2010-06-07 08:12:02 PDT
Landed as http://trac.webkit.org/changeset/60782