Bug 38802

Summary: svn-apply: Finish removing header-parsing from the calling code
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: cjerdonek, dbates, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
cjerdonek: commit-queue-
Proposed patch none

Chris Jerdonek
Reported 2010-05-08 10:26:32 PDT
There are still a few remaining places where svn-apply and -unapply parse header lines. This report is to finish moving that logic to the parsing methods of VCSUtils.pm.
Attachments
Proposed patch (16.51 KB, patch)
2010-05-08 23:16 PDT, Chris Jerdonek 		cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Proposed patch (16.43 KB, patch)
2010-05-08 23:22 PDT, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-05-08 23:16:41 PDT
Created attachment 55489 [details] Proposed patch
Chris Jerdonek
Comment 2 2010-05-08 23:22:30 PDT
Created attachment 55490 [details] Proposed patch Deleted duplicate lines from parseGitDiffHeader(). Fixed typo in ChangeLog.
Daniel Bates
Comment 3 2010-05-09 00:15:45 PDT
Comment on attachment 55490 [details] Proposed patch Looks good to me.
Chris Jerdonek
Comment 4 2010-05-09 00:21:51 PDT
Comment on attachment 55490 [details] Proposed patch Clearing flags on attachment: 55490 Committed r59048: <http://trac.webkit.org/changeset/59048>
Chris Jerdonek
Comment 5 2010-05-09 00:21:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.