Bug 38802 - svn-apply: Finish removing header-parsing from the calling code
Summary: svn-apply: Finish removing header-parsing from the calling code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-08 10:26 PDT by Chris Jerdonek
Modified: 2010-05-09 00:21 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (16.51 KB, patch)
2010-05-08 23:16 PDT, Chris Jerdonek
cjerdonek: commit-queue-
Details | Formatted Diff | Diff
Proposed patch (16.43 KB, patch)
2010-05-08 23:22 PDT, Chris Jerdonek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-05-08 10:26:32 PDT
There are still a few remaining places where svn-apply and -unapply parse header lines.  This report is to finish moving that logic to the parsing methods of VCSUtils.pm.
Comment 1 Chris Jerdonek 2010-05-08 23:16:41 PDT
Created attachment 55489 [details]
Proposed patch
Comment 2 Chris Jerdonek 2010-05-08 23:22:30 PDT
Created attachment 55490 [details]
Proposed patch

Deleted duplicate lines from parseGitDiffHeader().  Fixed typo in ChangeLog.
Comment 3 Daniel Bates 2010-05-09 00:15:45 PDT
Comment on attachment 55490 [details]
Proposed patch

Looks good to me.
Comment 4 Chris Jerdonek 2010-05-09 00:21:51 PDT
Comment on attachment 55490 [details]
Proposed patch

Clearing flags on attachment: 55490

Committed r59048: <http://trac.webkit.org/changeset/59048>
Comment 5 Chris Jerdonek 2010-05-09 00:21:58 PDT
All reviewed patches have been landed.  Closing bug.