Bug 38790

Summary:

new-run-webkit-tests: clean up newline handling in printing again!

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Dirk Pranke

Reported 2010-05-07 19:45:13 PDT

Okay, the bug fix in bug 38616 wasn't right in some cases and was confusing. Try again, and be consistent about calling conventions to the printing entry points.

Attachments
Patch (10.92 KB, patch) 2010-05-07 19:52 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2010-05-07 19:52:33 PDT

Created attachment 55451 [details] Patch

David Levin

Comment 2 2010-05-10 15:26:02 PDT

Comment on attachment 55451 [details] Patch Looks fine.

Dirk Pranke

Comment 3 2010-05-10 17:00:27 PDT

Comment on attachment 55451 [details] Patch Clearing flags on attachment: 55451 Committed r59106: <http://trac.webkit.org/changeset/59106>

Dirk Pranke

Comment 4 2010-05-10 17:00:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.