Bug 38790 - new-run-webkit-tests: clean up newline handling in printing again!
Summary: new-run-webkit-tests: clean up newline handling in printing again!
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 19:45 PDT by Dirk Pranke
Modified: 2010-05-10 17:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch (10.92 KB, patch)
2010-05-07 19:52 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-05-07 19:45:13 PDT
Okay, the bug fix in bug 38616 wasn't right in some cases and was confusing.

Try again, and be consistent about calling conventions to the printing entry points.
Comment 1 Dirk Pranke 2010-05-07 19:52:33 PDT
Created attachment 55451 [details]
Patch
Comment 2 David Levin 2010-05-10 15:26:02 PDT
Comment on attachment 55451 [details]
Patch

Looks fine.
Comment 3 Dirk Pranke 2010-05-10 17:00:27 PDT
Comment on attachment 55451 [details]
Patch

Clearing flags on attachment: 55451

Committed r59106: <http://trac.webkit.org/changeset/59106>
Comment 4 Dirk Pranke 2010-05-10 17:00:32 PDT
All reviewed patches have been landed.  Closing bug.