Bug 38784

Summary:

need new chromium win baselines for bugfix for chromium bug 43319

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	eric: review+

Dirk Pranke

Reported 2010-05-07 17:23:23 PDT

We need new chromium win baselines for bugfix for chromium bug 43319

Attachments
patch (1.14 MB, patch) 2010-05-07 17:39 PDT, Dirk Pranke	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2010-05-07 17:39:40 PDT

Created attachment 55441 [details] patch baselines added. The rebaseline tool was working correctly most likely when Jeremy was trying to get the windows baselines. The problem is, that it would pull from the XP bots and try to put the files in chromium win, which would only pass on a Win XP machine (and is wrong, to boot). The rebaseline tool isn't smart enough to handle version-specific baselines (although it can pull into the right directories if you tell it to).

Eric Seidel (no email)

Comment 2 2010-05-07 21:48:50 PDT

Comment on attachment 55441 [details] patch rs=me.

Dirk Pranke

Comment 3 2010-05-10 12:53:48 PDT

Committed r59092: <http://trac.webkit.org/changeset/59092>

Note You need to log in before you can comment on or make changes to this bug.