Bug 38784 - need new chromium win baselines for bugfix for chromium bug 43319
Summary: need new chromium win baselines for bugfix for chromium bug 43319
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 17:23 PDT by Dirk Pranke
Modified: 2010-05-10 12:53 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.14 MB, patch)
2010-05-07 17:39 PDT, Dirk Pranke
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-05-07 17:23:23 PDT
We need new chromium win baselines for bugfix for chromium bug 43319
Comment 1 Dirk Pranke 2010-05-07 17:39:40 PDT
Created attachment 55441 [details]
patch

baselines added. The rebaseline tool was working correctly most likely when Jeremy was trying to get the windows baselines. The problem is, that it would pull from the XP bots and try to put the files in chromium win, which would only pass on a Win XP machine (and is wrong, to boot).

The rebaseline tool isn't smart enough to handle version-specific baselines (although it can pull into the right directories if you tell it to).
Comment 2 Eric Seidel (no email) 2010-05-07 21:48:50 PDT
Comment on attachment 55441 [details]
patch

rs=me.
Comment 3 Dirk Pranke 2010-05-10 12:53:48 PDT
Committed r59092: <http://trac.webkit.org/changeset/59092>