Bug 38776

Summary: [chromium] Remove temporary relative include paths
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: WebKit APIAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch
none
v2 patch (make the style bot happy) dglazkov: review+

Darin Fisher (:fishd, Google)
Reported 2010-05-07 14:36:49 PDT
[chromium] Remove temporary relative include paths
Attachments
v1 patch (11.87 KB, patch)
2010-05-07 14:38 PDT, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
v2 patch (make the style bot happy) (12.02 KB, patch)
2010-05-07 16:21 PDT, Darin Fisher (:fishd, Google) 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2010-05-07 14:38:29 PDT
Created attachment 55418 [details] v1 patch Note, there is some inconsistency style-wise with how we mix WebKit headers with WebCore headers. I'm not attempting to unify style in this patch.
WebKit Review Bot
Comment 2 2010-05-07 14:42:01 PDT
Attachment 55418 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/src/WebBindings.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/src/WebDataSourceImpl.h:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Fisher (:fishd, Google)
Comment 3 2010-05-07 15:57:19 PDT
Those style issues are related to what I wrote in comment #1. Please disregard them. I will deal with that class of style issue later.
Darin Fisher (:fishd, Google)
Comment 4 2010-05-07 16:21:47 PDT
Created attachment 55429 [details] v2 patch (make the style bot happy)
Dimitri Glazkov (Google)
Comment 5 2010-05-07 16:22:58 PDT
Comment on attachment 55429 [details] v2 patch (make the style bot happy) ok.
Darin Fisher (:fishd, Google)
Comment 6 2010-05-14 23:51:24 PDT
Landed as http://trac.webkit.org/changeset/59524
Note You need to log in before you can comment on or make changes to this bug.